Skip to content

impl(bigtable): cancel refresh_timer_ in QueryPlan destructor#15755

Merged
scotthart merged 2 commits intogoogleapis:mainfrom
scotthart:bigtable_query_plan_cancel_timer
Nov 13, 2025
Merged

impl(bigtable): cancel refresh_timer_ in QueryPlan destructor#15755
scotthart merged 2 commits intogoogleapis:mainfrom
scotthart:bigtable_query_plan_cancel_timer

Conversation

@scotthart
Copy link
Member

@scotthart scotthart commented Nov 12, 2025

No description provided.

@scotthart scotthart requested a review from a team November 12, 2025 23:16
@product-auto-label product-auto-label bot added the api: bigtable Issues related to the Bigtable API. label Nov 12, 2025
@gemini-code-assist
Copy link

gemini-code-assist bot commented Nov 12, 2025

Summary of Changes

Hello @scotthart, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a destructor for the QueryPlan class. This change is crucial for resource management, as it ensures that any active refresh_timer_ associated with a QueryPlan instance is properly canceled upon the object's destruction. This prevents potential issues such as resource leaks or attempts to access deallocated memory if the timer were to fire after the QueryPlan object has been destroyed.

Highlights

  • Destructor Implementation: Implemented the QueryPlan destructor to ensure proper cleanup of the refresh_timer_.
  • Timer Cancellation: Added logic to cancel the refresh_timer_ if it is valid when a QueryPlan object is destroyed, preventing potential resource leaks or dangling operations.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist[bot]
gemini-code-assist bot reviewed Nov 12, 2025
View reviewed changes
Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds a destructor to QueryPlan to cancel the refresh timer when the object is destroyed. This is a good practice to ensure timely cleanup of resources. The implementation looks correct and thread-safe. I approve these changes.

@codecov
Copy link

codecov bot commented Nov 12, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.96%. Comparing base (435056d) to head (18a69c2).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #15755      +/-   ##
==========================================
- Coverage   92.96%   92.96%   -0.01%     
==========================================
  Files        2448     2448              
  Lines      226254   226257       +3     
==========================================
  Hits       210336   210336              
- Misses      15918    15921       +3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@scotthart scotthart enabled auto-merge (squash) November 13, 2025 16:27
@scotthart scotthart merged commit 829bce3 into googleapis:main Nov 13, 2025
68 of 70 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@diegomarquezp diegomarquezp diegomarquezp approved these changes

+1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: bigtable Issues related to the Bigtable API.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@scotthart @diegomarquezp